Asynchronicity improvements#2753
Merged
Martí Climent (marticliment) merged 24 commits intomainfrom Sep 19, 2024
Merged
Conversation
… into better-async
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, asynchronicity is only used when waiting for subprocesses to write on stout, while all the parsing is done on the UI thread, causing some stuttering and small lagging.
This PRs refractors the PackageManager's internal calls into synchronous methods, that are then called on a thread via
Task.Run, moving all the packagemanager-related processing to the background and improving UI smoothness.The most notable change is the lack of stuttering when installed packages are loaded and added to the list