Skip to content

Fix the vcpkg (normalized) icon ID#3100

Merged
Martí Climent (marticliment) merged 1 commit intoDevolutions:mainfrom
mrixner:fix-vcpkg-icon-id
Dec 20, 2024
Merged

Fix the vcpkg (normalized) icon ID#3100
Martí Climent (marticliment) merged 1 commit intoDevolutions:mainfrom
mrixner:fix-vcpkg-icon-id

Conversation

@mrixner
Copy link
Contributor

@mrixner mrixner commented Dec 20, 2024

  • I have read the contributing guidelines, and I agree with the Code of Conduct.
  • Have you checked that there aren't other open pull requests for the same changes?
  • Have you tested that the committed code can be executed without errors?
  • This PR is not composed of garbage changes used to farm GitHub activity to enter potential Crypto AirDrops.
    Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the contributors' time, who have to spend their free time reviewing, fixing, and testing code that does not even compile breaks other features, or does not introduce any useful changes. I appreciate your understanding.

Winget package IDs are normalized to remove the publisher; this pull request does the same thing to vcpkg packages, removing the triplet so they can take advantage of the icons in the screenshot database. It also makes it so the AbstractPackagesPage icons take into account this normalization, which it doesn't seem as if it was doing before.

@marticliment Martí Climent (marticliment) merged commit 997acb1 into Devolutions:main Dec 20, 2024
@mrixner mrixner deleted the fix-vcpkg-icon-id branch December 20, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants