Fix the Improved Icon Detection#3347
Merged
Martí Climent (marticliment) merged 2 commits intoDevolutions:mainfrom Feb 26, 2025
Merged
Fix the Improved Icon Detection#3347Martí Climent (marticliment) merged 2 commits intoDevolutions:mainfrom
Martí Climent (marticliment) merged 2 commits intoDevolutions:mainfrom
Conversation
Martí Climent (marticliment)
approved these changes
Feb 26, 2025
6ae08be
into
Devolutions:main
2 checks passed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the contributors' time, who have to spend their free time reviewing, fixing, and testing code that does not even compile breaks other features, or does not introduce any useful changes. I appreciate your understanding.
This PR fixes #3189; that PR was checking for sources in the manager section and was also partially getting the logic wrong. Here's the tested, updated, revised, etc logic (for ALL checks, as they are in the code right now):
Winget - Steam: convert to
steam:{id}Winget - Local PC: remove anything before a
\Winget - Microsoft Store: remove the publisher (or anything before a
\if there is no publisher) and the_version_architecture__random-id(note that if the version has multiple underscores, only the last four underscores remove what is after them, so there can be underscores in a normalized ID)Winget: remove the publisher
Scoop: remove
.appChocolatey: remove
.installand.portablevcpkg: remove the triplet and any build options
All are in lowercase.
If you accept this PR, you might want to reference something like this table here. (this page also appears to be incorrect; it says "Package ids will be normalized. This means that the id will show in lowercase, and the spaces, underscores and dots (" ", "_", ".") will be replaced by dashes ("-")." but I don't think that happens anymore? I could be wrong about that though.)