Skip to content

Improvements#531

Merged
Martí Climent (marticliment) merged 5 commits intoDevolutions:mainfrom
panther7:improvements
Dec 28, 2022
Merged

Improvements#531
Martí Climent (marticliment) merged 5 commits intoDevolutions:mainfrom
panther7:improvements

Conversation

@panther7
Copy link
Copy Markdown
Contributor

@panther7 Filip Mösner (panther7) commented Dec 27, 2022

ref #529

@panther7
Copy link
Copy Markdown
Contributor Author

Done, check it, if tis ok for you.

Martí Climent (@marticliment)

@panther7 Filip Mösner (panther7) changed the title Draft: Improvements Improvements Dec 27, 2022
@panther7
Copy link
Copy Markdown
Contributor Author

2022-12-27 21 29 27

@ppvnf
Copy link
Copy Markdown
Contributor

Would it be possible to do this automatically to all translators (or at least the ones that have a Github account)?

@panther7
Copy link
Copy Markdown
Contributor Author

Martí Climent (@marticliment) Please try this fix f20cb99 for ISS.

@panther7
Copy link
Copy Markdown
Contributor Author

Filip Mösner (panther7) commented Dec 27, 2022

pedronovaes (@ppvnf) I can't check, if "name" is github accout. You can add "@" prefix for your name/nick and link will be created.

//edit: i added "automake" link, if you in contributors list

@panther7 Filip Mösner (panther7) force-pushed the improvements branch 2 times, most recently from 510a927 to b6854eb Compare December 27, 2022 21:17
@marticliment
Copy link
Copy Markdown
Collaborator

Martí Climent (@marticliment) Please try this fix f20cb99 for ISS.

It seems to work for me. Thank you!

P.D. I can merge that, right?

@panther7
Copy link
Copy Markdown
Contributor Author

Yes, u can

@ppvnf
Copy link
Copy Markdown
Contributor

I've tested it and it works great. Thanks! Is there a simple way using Tolgee for Martí Climent (@marticliment) to add the other translators as contributors so they also have their Github profiles linked? Also, should I manually link my profile in the readme?

@panther7
Copy link
Copy Markdown
Contributor Author

Links from translators is not secured, I think, this is good solution ;-)

@marticliment
Copy link
Copy Markdown
Collaborator

Martí Climent (marticliment) commented Dec 28, 2022

I've tested it and it works great. Thanks! Is there a simple way using Tolgee for Martí Climent (@marticliment) to add the other translators as contributors so they also have their Github profiles linked? Also, should I manually link my profile in the readme?

Every contributor will need to add their username instead of their name

I'll add the ability to show also links in the readme (id you were to link that manually, it would get erased after the readme was generated again) This was already done by Filip Mösner (@panther7), i don¡t know where I looked that i couldn't find it, but now I see whet you did.
Great job!

@marticliment Martí Climent (marticliment) merged commit 7be860b into Devolutions:main Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants