Skip to content

Fix: Steam and MSStore aren't displayed in error message#561

Merged
Martí Climent (marticliment) merged 2 commits intoDevolutions:mainfrom
ppvnf:f-string-store-name
Dec 30, 2022
Merged

Fix: Steam and MSStore aren't displayed in error message#561
Martí Climent (marticliment) merged 2 commits intoDevolutions:mainfrom
ppvnf:f-string-store-name

Conversation

@ppvnf
Copy link
Copy Markdown
Contributor

instead of showing only "Local PC", using f-string allows "Steam" and "MSStore" as well. I'm not sure, though, if it would be better to have a custom message for MSStore

Captura de tela 2022-12-30 113644
change to winget and scoop
Captura de tela 2022-12-30 113625

@marticliment
Copy link
Copy Markdown
Collaborator

I would do _("Uninstallable [...] listed ad {0} can not be [...]").format(item.text(4)), so the string "Uninstallable [...] listed ad {0} can not be [...]" can be easily added to tolgee

marticliment suggestion to make easier to add in Tolgee 

Devolutions#561 (comment)
@ppvnf
Copy link
Copy Markdown
Contributor Author

Done

@marticliment Martí Climent (marticliment) merged commit 2560029 into Devolutions:main Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants