chore: add group_imports format rule#1637
Merged
Benoît Cortier (CBenoit) merged 2 commits intoDec 18, 2025
Merged
Conversation
This uses [group_imports](https://rust-lang.github.io/rustfmt/?version=v1.8.0&search=group_imports#group_imports), which is [present in IronRDP, sspi-rs, and IronVNC](https://github.com/search?q=org%3ADevolutions%20group_imports&type=code). `cargo +nightly fmt` was run afterwards.
Comment on lines
+7
to
+10
| use bytes::{Buf as _, BufMut as _}; | ||
| // We re-export these types, because they are used in the public API. | ||
| pub use bytes::{Bytes, BytesMut}; | ||
| use smol_str::SmolStr; |
There was a problem hiding this comment.
note: I don’t really like the mixed pub use and use like that. We use #[rustfmt::skip] in IronRDP. I wonder if there is an option for that today?
Contributor
Author
There was a problem hiding this comment.
There is no option for that as of yet, only this comment.
Benoît Cortier (CBenoit)
approved these changes
Dec 18, 2025
Benoît Cortier (CBenoit)
merged commit fb90650
into
Devolutions:master
42 checks passed
30 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses group_imports, which is present in IronRDP, sspi-rs, and IronVNC.
cargo +nightly fmtwas run afterwards.