feat(dgw): extend subkey capabilities to KDC tokens#334
Merged
Benoît Cortier (CBenoit) merged 3 commits intomasterfrom Sep 23, 2022
Merged
feat(dgw): extend subkey capabilities to KDC tokens#334Benoît Cortier (CBenoit) merged 3 commits intomasterfrom
Benoît Cortier (CBenoit) merged 3 commits intomasterfrom
Conversation
With this change, a subkey is allowed to sign a short-lived KDC token.
Contributor
|
Benoît Cortier (@CBenoit) bien que les subkeys soient présentement utilisés uniquement pour des short-lived tokens, et que DVLS n'utilise pas encore les subkeys, ajouter une valeur maximale de validité dans le gateway pourrait causer problème dans le futur, surtout dans les cas ou la validité est configurable. Il me semble que c'est le cas dans DVLS, ça donnerait des cas ou le gateway refuserait des tokens d'une durée de plus de 10 minutes, si l'admin le configure pour utiliser 15 minutes, par exemple. |
Member
Author
|
J’ai changé la durée maximale à deux heures. Je vais aussi effectuer un suivi pour valider que l’utilisateur ne peut pas configurer une durée de validité supérieure à deux heures dans le UI de DVLS. |
Marc-André Moreau (awakecoding)
approved these changes
Sep 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, a subkey is allowed to sign a short-lived KDC token.