[DEVOPS-4158] feat: add context support to client requests#31
Merged
Richard Boisvert (rbstp) merged 1 commit intomasterfrom Jan 9, 2026
Merged
[DEVOPS-4158] feat: add context support to client requests#31Richard Boisvert (rbstp) merged 1 commit intomasterfrom
Richard Boisvert (rbstp) merged 1 commit intomasterfrom
Conversation
|
🤖 You did not bump the version, a release won't be created |
9940689 to
8d02578
Compare
8d02578 to
8221ad5
Compare
8221ad5 to
d992a9f
Compare
There was a problem hiding this comment.
Pull request overview
This pull request adds comprehensive context support to all client HTTP requests, enabling cancellation, timeout control, and context value propagation throughout the DVLS Go SDK. The changes maintain backward compatibility by keeping existing methods and adding new *WithContext variants.
Key Changes:
- Introduced
RequestWithContextandrawRequestWithContextmethods usinghttp.NewRequestWithContextfor proper context handling - Added
*WithContextvariants for all public API methods across vaults, server info, and entry operations - Implemented comprehensive test suite validating context cancellation, timeout, and propagation behavior
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| dvls.go | Added RequestWithContext and rawRequestWithContext methods; existing Request method now delegates to context variant with context.Background() |
| authentication.go | Added context support to internal login and isLogged methods for proper context propagation |
| vaults.go | Added *WithContext variants for all vault operations (Get, New, Update, Delete, ValidatePassword) |
| server.go | Added *WithContext variants for server info and timezone retrieval methods |
| entry_credential.go | Added *WithContext variants for all credential entry operations with proper internal context threading |
| entry_certificate.go | Added *WithContext variants for certificate entry operations including file uploads |
| entry_website.go | Added *WithContext variants for website entry operations |
| entry_host.go | Added *WithContext variants for host entry operations |
| entry_attachments.go | Updated internal attachment methods to accept and propagate context |
| context_test.go | New comprehensive test suite covering cancellation, timeout, and context propagation scenarios |
| VERSION | Bumped version from 0.14.0 to 0.15.0 (appropriate minor version increment) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Dion Gionet Mallet (dion-gionet)
approved these changes
Jan 9, 2026
Merged
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C'est surtout pour ne plus devoir faire un wrapping de timeout dans external-secrets/external-secrets#5712
Summary
Add
context.Contextsupport to all client HTTP requests, enabling request cancellation, timeouts, and context value propagation.Changes
RequestWithContextas the core context-aware request handler*WithContextvariants for all public service methods:Vaults: Get, New, Update, Delete, ValidatePasswordEntryCredentialService: Get, GetById, New, Update, Delete, DeleteByIdEntryCertificateService: Get, GetFileContent, GetPassword, NewURL, NewFile, Update, DeleteEntryHostService: Get, GetHostDetailsEntryWebsiteService: Get, GetWebsiteDetailsClient: GetPublicServerInfo, GetPrivateServerInfo, GetServerTimezonescontext.Background()Tests