Skip to content

build(deps): remove num-bigint-dig #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2025
Merged

build(deps): remove num-bigint-dig #425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

126 changes: 19 additions & 107 deletions ffi/wasm/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions picky-asn1-x509/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,19 +22,19 @@ picky-asn1-der = { version = "0.5", path = "../picky-asn1-der" }
serde = { version = "1", features = ["derive"] }
oid = { version = "0.2", features = ["serde_support"] }
base64 = "0.22"
num-bigint-dig = { version = "0.8", optional = true }
crypto-bigint = { version = "=0.7.0-rc.8", optional = true, features = ["alloc"], default-features = false }
widestring = { version = "1.1", default-features = false, features = ["alloc"], optional = true }
zeroize = { version = "1.8", optional = true }

[dev-dependencies]
num-bigint-dig = "0.8"
crypto-bigint = { version = "=0.7.0-rc.8", features = ["alloc"], default-features = false }
pretty_assertions = "1.4"
hex = "0.4"
expect-test = "1"
picky-test-data = { path = "../picky-test-data", version = "0.1" }

[features]
legacy = ["num-bigint-dig"]
legacy = ["crypto-bigint"]
pkcs7 = ["widestring"]
pkcs12 = []
ctl = ["pkcs7"]
Expand Down
12 changes: 9 additions & 3 deletions picky-asn1-x509/src/certificate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ mod tests {
use crate::{DirectoryName, Extension, KeyIdentifier, KeyUsage};
use base64::Engine as _;
use base64::engine::general_purpose;
use num_bigint_dig::BigInt;
use crypto_bigint::BoxedUint;
use picky_asn1::bit_string::BitString;
use picky_asn1::date::UTCTime;

Expand Down Expand Up @@ -218,7 +218,10 @@ mod tests {

let subject_public_key_info = SubjectPublicKeyInfo::new_rsa_key(
IntegerAsn1::from(encoded[165..422].to_vec()),
BigInt::from(65537).to_signed_bytes_be().into(),
BoxedUint::from(65537u32)
.to_be_bytes_trimmed_vartime()
.into_vec()
.into(),
);
check_serde!(subject_public_key_info: SubjectPublicKeyInfo in encoded[133..427]);

Expand All @@ -245,7 +248,10 @@ mod tests {

let tbs_certificate = TbsCertificate {
version: ExplicitContextTag0(Version::V3),
serial_number: BigInt::from(935548868).to_signed_bytes_be().into(),
serial_number: BoxedUint::from(935548868u32)
.to_be_bytes_trimmed_vartime()
.into_vec()
.into(),
signature: signature_algorithm.clone(),
issuer,
validity,
Expand Down
Loading