fix: fall back to non-packaged app root when no AppX identity#19
Merged
Conversation
pinget unconditionally pointed its default app root at the WinGet
packaged LocalState, so any first-run command from a non-packaged,
non-elevated process tried to create
%ProgramData%\Microsoft\WinGet\{sid}\settings\pkg\... and failed with
"Access is denied" — making pinget unusable when bundled by callers
like UniGetUI. Detect package identity via GetCurrentPackageFullName
and, when absent, default the app root to %LOCALAPPDATA%\Devolutions\
Pinget; PINGET_APPROOT still opts a packaged caller back into the
WinGet LocalState layout.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Marc-André Moreau (mamoreau-devolutions)
previously approved these changes
May 12, 2026
Mirrors the Rust fix in NormalizeAppRoot: detect AppX package identity
via GetCurrentPackageFullName and, when absent, default the app root to
%LOCALAPPDATA%\Devolutions\Pinget instead of WinGet's SYSTEM-owned
secure-settings location under %ProgramData%\Microsoft\WinGet\{sid}\
settings\pkg\Microsoft.DesktopAppInstaller. This keeps the dotnet tool
and PowerShell module usable from non-packaged, non-elevated callers.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Marc-André Moreau (mamoreau-devolutions)
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pinget unconditionally pointed its default app root at the WinGet packaged LocalState, so any first-run command from a non-packaged, non-elevated process tried to create
%ProgramData%\Microsoft\WinGet{sid}\settings\pkg... and failed with "Access is denied" — making pinget unusable when bundled by callers like UniGetUI. Detect package identity via GetCurrentPackageFullName and, when absent, default the app root to %LOCALAPPDATA%\Devolutions\ Pinget; PINGET_APPROOT still opts a packaged caller back into the WinGet LocalState layout.