Enhance pinget upgrade output #23
Merged
Merged
Conversation
Marc-André Moreau (mamoreau-devolutions)
approved these changes
May 15, 2026
16fd47e
into
master
12 of 13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pinget upgrade was diverging from winget upgrade in two directions — silently dropping real upgrades (.NET SDK 10/9, Python 3.14, App Installer, Microsoft Teams correlation) and inventing phantom ones (mis-routed Git, side-by-side WindowsAppRuntime, Edge MSIX stub, Notepad++ Store stub). Root cause: pinget was correlating installed packages by display name only, while winget uses the v2 index's identity tables (pfns2, productcodes2, upgradecodes2, norm_names2, norm_publishers2) and the catalog's versionData.mszyml aMiV/aMaV ranges.
This branch ports the missing pieces to both implementations (Rust + C#, kept in lockstep per AGENTS.md), adds a structured parity harness, and verifies byte-equivalent output on the development machine.
Behavior changes
Aligned on both implementations (rust/crates/pinget-core/src/lib.rs and dotnet/src/Devolutions.Pinget.Core/):