Fix PE RFC3161 timestamps in code mode#16
Closed
Bradley Grainger (bgrainger) wants to merge 1 commit into
Closed
Conversation
Propagate code-mode RFC3161 timestamp options into PE/WinMD signing so top-level PE targets and nested PE payloads inside signed containers receive Microsoft Authenticode timestamp attributes. Add regression coverage for top-level PE timestamping and for nested DLLs inside a .nupkg. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Bradley Grainger (@bgrainger) I had another pull request ready with a bunch of fixes, but you caught something else, so I just incorporated it into #15 things go way too fast with AI these days ;) |
Marc-André Moreau (mamoreau-devolutions)
added a commit
that referenced
this pull request
May 25, 2026
## Summary - add portable Artifact Signing remote-sign embedding for CAB, MSI/MSP, generic catalogs, and flat MSIX/AppX final signing - add native-shaped portable batch ergonomics, expanded credential resolution, and non-PE timestamp persistence - incorporate [#16](#16) by propagating code-mode RFC3161 timestamp options into PE/WinMD signing - update docs and integration tests for the expanded replacement surface ## Validation - cargo fmt --all - cargo clippy --workspace --all-targets --locked - cargo test --workspace --locked - targeted Artifact Signing integration tests - targeted code-mode RFC3161 timestamp regression tests from #16 --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Bradley Grainger <bradley.grainger@logos.com>
Contributor
|
...and merged, so.closing this PR. Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #10 / #11.
As per #10 (comment) the outer NuGet package was signed and timestamped, but the DLLs inside were not time-stamped. This PR fixes that.
AI-generated Text Below
Summary
codemode RFC3161 timestamp options into PE/WinMD signing.nupkgcontainersRepro
Using
psign-tool code --mode portableto sign a realLogos.Test.1.0.0.nupkgpackage with Azure Artifact Signing and--timestamp-url http://timestamp.acs.microsoft.com/:Logos.Test.dllsignature did notTesting
cargo test --test code_commandcargo test -- --skip code_signing_vector_manifest_committed_entries_are_current