Use psign for self-signing release artifacts#3
Merged
Marc-André Moreau (mamoreau-devolutions) merged 12 commits intoMay 20, 2026
Merged
Use psign for self-signing release artifacts#3Marc-André Moreau (mamoreau-devolutions) merged 12 commits into
Marc-André Moreau (mamoreau-devolutions) merged 12 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Pass the older SIGNER_DIGEST_SIGN_INFO_V1 layout to SignerSignEx3 for the basic Authenticode digest callback used by Azure Key Vault signing, while preserving the Windows crate layout for decoupled DLL signing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
SignerSignEx3 may invoke the Authenticode digest callback outside the caller thread. Store the Azure Key Vault signing state behind a process-wide mutex so the callback can reach it reliably, and surface non-secret callback errors in CI logs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Azure Key Vault keys/sign uses base64url-encoded digest and signature values. Update the REST helper and local psign-server mock to match Azure, and enable the Windows Key Vault PE signing E2E test with timestamping. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add sign-time RFC3161 timestamping to portable PE signing so Azure Key Vault self-signing can run from a Linux psign-tool while preserving timestamped Authenticode signatures. Switch the release sign_windows job to ubuntu-latest and have it download the Linux x64 psign-tool artifact to sign Windows executables in portable mode with the existing Key Vault and timestamp settings. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Marc-André Moreau (mamoreau-devolutions)
requested a review
from a team
as a code owner
Marc-André Moreau (mamoreau-devolutions)
merged commit ed81a1d
into
master
11 checks passed
Marc-André Moreau (mamoreau-devolutions)
deleted the
awakecoding/psign-self-signing
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dotnet toolinstallation forDevolutions.Psign.Tool.psign-tooland move Windows executable signing to a Linux runner usingpsign-tool --mode portable sign.psign-serverfor portable/windows Key Vault and timestamped portable PE signing.Validation
cargo fmt --allcargo test -p psign --test cli_pe_digest azure_key_vault --features azure-kv-sign,timestamp-server,timestamp-http -- --nocapturecargo clippy --workspace --all-targets --lockedcargo test --workspace --lockedpsign-tool.exefiles are AuthenticodeValidand include DigiCert RFC3161 timestamp attributes (1.3.6.1.4.1.311.3.3.1).