feat: Add Route53 hosted zones and DNS records browser#38
Conversation
- Add Route53 service and Route53 Browser feature to domain catalog - Implement ListHostedZones and ListResourceRecordSets with pagination - Add Route53ClientAPI interface and client initialization in repository - Add 3 TUI screens: zone list, record list, record detail - Support filtering on both zone list and record list views - Add HostedZone and DNSRecord models with DisplayTitle/FilterText - Add comprehensive tests for API methods and model functions
| instanceID string | ||
| } | ||
|
|
||
| type route53ZonesLoadedMsg struct { |
There was a problem hiding this comment.
제가 go는 잘 모르는데 Type는 별도로 types.go로 모듈로 분리했던것 같아요
There was a problem hiding this comment.
혹시 types.go를 쓰는 게 흔한 패턴인가요? Effective Go나 Google Golang Style guide, Reddit 등의 discussion에서는 centralized해서 보는 것보다는 사용하는 곳 근처에 두는 걸 recommend합니다!
There was a problem hiding this comment.
https://github.com/gravitational/teleport/blob/dda523e52f9a09e1811c27b0776fa1598d5c422a/tool/tctl/common/config/global.go#L45
teleport 에서도 분리해서 쓴걸 확인할 수 있습니다.
이건 패턴이라...
| route53RecordIdx int | ||
| route53RecordFilter string | ||
| route53RecordFilterActive bool | ||
| selectedRoute53Record *awsservice.DNSRecord |
There was a problem hiding this comment.
이 healthcheck로 이해했습니다!
필요할 거 같다는 말씀이신가요?
There was a problem hiding this comment.
(마이너) 아! 옵션이어서 당장은 필요없을 것 같아요! 나중에 필요하면 추가하면 될 것 같습니다.
There was a problem hiding this comment.
오! 그런 사항은 GitHub Issue에 등록해주시면 진행해보겠습니다!
There was a problem hiding this comment.
@choisungwook offered insights to possible implementation of Route 53 healthcheck to unic.
Suggested adding a new GitHub Issue for that specific enhancement.
YoungJinJung
left a comment
YoungJinJung
left a comment
There was a problem hiding this comment.
please use in english for everything(eg. comment, discuss. etc)
3 participants
Summary
Add Route53 support to the TUI (PLAN.md M3.6 phase 1 — read-only browsing). Users can list hosted zones, drill into DNS records, and view record details with filtering on both views.
New files:
route53_model.go— HostedZone and DNSRecord modelsroute53.go— ListHostedZones and ListResourceRecordSets with paginationroute53_test.go— 12 tests covering API methods and modelsModified files:
Related Issues
Closes #13
Validation
make test— all tests pass (existing + 12 new Route53 tests)make build— binary compiles successfullyChecklist