feat: add Secrets Manager browser (M3.9)#47
Merged
jjjjjjeonda86 merged 1 commit intomainfrom Mar 27, 2026
Merged
Conversation
- Add SecretsManagerClientAPI interface and client to AwsRepository - Implement ListSecrets() and GetSecretDetail() with JSON key/value parsing - Register ServiceSecretsManager and FeatureSecretsBrowser in domain catalog - Add screenSecretList and screenSecretDetail TUI screens with filter support - Add Secret and SecretDetail models with DisplayTitle() and FilterText() - Add mock-based tests for list, get, and model methods
jjjjjjeonda86
force-pushed
the
feat/secrets-manager-browser
branch
from
aeec6e4 to
0237c78
Compare
|
혹시 현재 PR코드 말고 다른 로직에서, 이 도구가 하는 행위를 로깅하는게 있을까요? secretmanager 값을 읽고 편집하는 행위가 어디에 로깅되면 위험할 것 같아서 질문드립니다! |
choisungwook
approved these changes
Mar 27, 2026
Contributor
Author
해당 기능은 secretsmanager 조회만 가능하고, 로깅 패키지도 없습니다 ~(API 호출만 기록) |
YoungJinJung
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add AWS Secrets Manager browsing feature to the TUI (M3.9).
/key)Related Issues
Closes #46
Validation
make test— all tests pass (12 new tests insecretsmanager_test.go)make build— binary compiles cleanlyChecklist