feat: add inspector security rule packs#98
Merged
Conversation
- add built-in Security Group, RDS, IAM, Secrets Manager, and S3 inspector checks - enrich repository models and S3 client interfaces for new scan coverage - update Inspector UI copy and README to reflect shipped rule packs
- use a secrets-specific high-severity threshold for overdue rotation - add regression coverage for medium and high overdue rotation findings
This comment was marked as duplicate.
This comment was marked as duplicate.
- restore IAM access key severity to the IAM high-age constant - restore secrets rotation severity to the secrets high-age constant - tighten boundary tests around the domain-specific thresholds
Contributor
Author
|
/q review |
Contributor
There was a problem hiding this comment.
Summary
This PR successfully implements built-in Security Inspector rule packs for AWS resources. The implementation is well-structured with comprehensive test coverage and proper error handling throughout.
Key Changes Reviewed
- Security scanning rules: Implemented checks for Security Groups (SSH/RDP/all-traffic exposure), RDS (encryption, public access, backups), IAM access keys (age-based alerts), Secrets Manager (rotation monitoring), and S3 buckets (public ACLs, policies, versioning)
- Model enrichments: Added essential security-related fields to RDSInstance and Secret models
- Interface extensions: Properly extended S3ClientAPI with required methods for security checks
- Test coverage: Comprehensive unit tests validate all scanner logic and edge cases
Review Result
No blocking defects found. The code is production-ready with:
- ✅ Proper error handling and nil checks
- ✅ Well-tested with table-driven tests
- ✅ Secure implementation of security checks
- ✅ Appropriate severity classifications
- ✅ Clean separation of concerns
The implementation correctly identifies security misconfigurations and provides actionable recommendations to users.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
YoungJinJung
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the first built-in Security Inspector rule packs with these checks:
It also enriches the RDS and Secrets models plus the S3 client interface so the scanners can evaluate live AWS state, and it updates Inspector UI copy and README to reflect the shipped rule coverage.
Related Issues
Closes #90
Closes #91
Closes #92
Validation
Checklist