Skip to content

Conversation

@keptsecret
Copy link
Contributor

No description provided.

@devshgraphicsprogramming
Copy link
Member

@keptsecret the HLSL Path Tracer (on the other branch) works with a quantized sequence from the latest commit here, correct?

@AnastaZIuk
Copy link
Member

all of those asserts is typo & false trigger

store_type get(const uint16_t idx) { assert(idx > 0 && idx < 1); return data; }

void set(const uint16_t idx, const store_type value) { assert(idx > 0 && idx < 1); data = value; }

scalar_type get(const uint16_t idx) { assert(idx > 0 && idx < Dim); return data[idx]; }

void set(const uint16_t idx, const scalar_type value) { assert(idx > 0 && idx < Dim); data[idx] = value; }

since index can be 0

static this_t create(const vector<store_type, Dimension> value)
{
this_t seq;
seq.data = store_type(0u);
NBL_UNROLL for (uint16_t i = 0; i < Dimension; i++)
seq.set(i, value[i]);

should be idx < Dim or idx >= 0 && idx < Dim

@keptsecret
Copy link
Contributor Author

@keptsecret the HLSL Path Tracer (on the other branch) works with a quantized sequence from the latest commit here, correct?

Yep, last I checked still works

@AnastaZIuk AnastaZIuk merged commit 8a5e648 into master Jan 30, 2026
20 checks passed
@AnastaZIuk AnastaZIuk deleted the changes_to_quantized_sequence branch January 30, 2026 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants