fix: resolve issues #676, #677, #678, #679#756
Merged
Devsol-01 merged 1 commit intoDevsol-01:mainfrom Apr 29, 2026
Merged
Conversation
…ol-01#679 Devsol-01#676 - Goal Milestone Detection Async Queue - Add MilestoneQueueService with in-process async queue (batches of 10, 500ms flush interval) replacing fire-and-forget loop in findMyGoals - Retry logic: up to 3 attempts with exponential backoff (2s * attempt) - Emits milestone.batch.achieved and milestone.detection.failed events - Register MilestoneQueueService in SavingsModule Devsol-01#677 - Product Capacity Race Condition Fix - Wrap subscribe() in DataSource.transaction() with SELECT FOR UPDATE pessimistic write lock on the product row - All capacity checks (count, amount) run inside the locked transaction - Add @VersionColumn() to UserSubscription for optimistic locking - Add migration 1800000000000-AddVersionToUserSubscriptions Devsol-01#678 - Withdrawal Fraud Detection - Add WithdrawalFraudService with velocity checks (5 req/hr, 50k/day), cooling-off period (30 days, max 5k), large-amount flagging (>=10k), and suspicious pattern detection (repeated similar amounts in 30min) - Emits withdrawal.fraud.flagged event for monitoring - Integrate into AdminWithdrawalService.approve(): HIGH risk blocks with ForbiddenException; MEDIUM+large routes to manual review queue - Register WithdrawalFraudService in AdminModule Devsol-01#679 - Compound Interest Calculation Fix - Replace simple interest with compound interest formula A=P(1+r/n)^(nt) - Add CompoundingFrequency enum (DAILY/WEEKLY/MONTHLY/QUARTERLY/ANNUALLY/ CONTINUOUS) configurable via SAVINGS_COMPOUNDING_FREQUENCY env var - Support continuous compounding via e^(rt) when frequency=0 - Register InterestCalculationService and InterestHistory in SavingsModule - Expose savings.compoundingFrequency in configuration.ts
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
@Mathews-25 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #676
closes #677
closes #678
closes #679
#676 - Goal Milestone Detection Async Queue
#677 - Product Capacity Race Condition Fix
#678 - Withdrawal Fraud Detection
#679 - Compound Interest Calculation Fix