feat: add reusable Button component with variants and replace 20+ instances#834
Open
zeroknowledge0x wants to merge 1 commit into
Open
feat: add reusable Button component with variants and replace 20+ instances#834zeroknowledge0x wants to merge 1 commit into
zeroknowledge0x wants to merge 1 commit into
Conversation
Create a standardized Button component with: - 5 variants: primary, secondary, outline, ghost, danger - 3 sizes: sm, md, lg - Loading state with spinner - Left/right icon support - Full-width option - Proper disabled states Replace inline button styles across 15 files: - FeaturedGoalCard, GoalCard, GoalOverviewCard - PassedProposalCard, ProposalCard, SavingsPoolCard - Settings, Portfolio, Referrals, Transactions - Notifications, Savings Pools, Savings, Support, GoalForm Fixes Devsol-01#828
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Author
|
Hi! 👋 I noticed the CI checks are showing as unstable. Looking at the workflow history, the Backend CI/CD Pipeline has been failing on the main branch as well (the merge of PR #819 also failed). These appear to be pre-existing CI issues unrelated to this PR's changes. Would appreciate a review when you get a chance. Thanks! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Create a standardized, reusable Button component and replace inline button styles across the codebase.
Changes
New:
Button.tsxcomponentReplaced 20+ button instances across 15 files:
FeaturedGoalCard.tsx- Contribute Now, View DetailsGoalCard.tsx- ContributeGoalOverviewCard.tsx- Edit Goal, Add FundsPassedProposalCard.tsx- View detailsProposalCard.tsx- Vote Now (desktop + mobile)SavingsPoolCard.tsx- DepositSettingsClient.tsx- Save Preferencesportfolio/page.tsx- Export CSVreferrals/page.tsx- Copytransactions/page.tsx- Export CSVnotifications/page.tsx- Mark all readsavings-pools/page.tsx- Create New Goal, Clear Searchsavings/page.tsx- View TemplatesGoalForm.tsx- Create goalsupport/page.tsx- Send MessageTesting
Fixes #828