feat(frontend): reusable Button, wallet persistence, loading states, query caching#841
Open
king-aj-the-first wants to merge 1 commit into
Open
feat(frontend): reusable Button, wallet persistence, loading states, query caching#841king-aj-the-first wants to merge 1 commit into
king-aj-the-first wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@king-aj-the-first Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #828
closes #829
closes #830
closes #831
PR description
Summary
Button, replace raw<button>usage, persist wallet connection & improve reconnection flow, ensure loading skeletons exist, and enable React Query caching/persistence for balances and prices.What I changed
UI / Buttons: Standardized button usage by using the existing
Buttoncomponent across many components and replacing native<button>occurrences for consistent variants, sizes, loading and accessibility.Wallet connection & reconnection: Improved
WalletContextto persist last network, detect extension disconnect/lock, show reconnect UI, and invalidate caches when disconnect detected.connectionStatus(locked/disconnected), triggers cache invalidation for balances and surfacesWalletReconnectBanner.Loading states: Verified and preserved existing loading skeleton components and used them where appropriate (spinner, skeleton lines, card/table/transaction skeletons).
Client-side caching / React Query: Ensured React Query is configured with persistence and sensible TTLs; moved wallet balance fetching to React Query with keys and TTLs so balances and CoinGecko prices are cached (stale-while-revalidate).
queryKey: ['balances', address]withstaleTime: 30s,cacheTime: 5min; invalidation on wallet disconnect is applied.Acceptance criteria coverage
Buttonused across the app (variants, sizes, loading, icons, ARIA): implemented.WalletContextandWalletReconnectBanner.