Conversation
yuecideng
added
bug
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes OBJ material (.mtl) file copying during URDF mesh assembly/merging when the mesh reference includes directory components, ensuring the resolver looks for the .mtl alongside the resolved OBJ on disk.
Changes:
- Compute the OBJ’s
.mtlfilename from the OBJ basename (not the full referenced path) so dependency lookup/copy works correctly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the issue of mtl file copying when performing urdf merging if the visual mesh is obj format
Type of change
Checklist
black .command to format the code base.