Fix add_sensor_attachments mixing link elements into joints list#204
Draft
Copilot wants to merge 2 commits intocjt/modify_urdf_assemblyfrom
Draft
Fix add_sensor_attachments mixing link elements into joints list#204Copilot wants to merge 2 commits intocjt/modify_urdf_assemblyfrom
add_sensor_attachments mixing link elements into joints list#204Copilot wants to merge 2 commits intocjt/modify_urdf_assemblyfrom
Conversation
4 tasks
Co-authored-by: chase6305 <61959467+chase6305@users.noreply.github.com> Agent-Logs-Url: https://github.com/DexForce/EmbodiChain/sessions/a3280364-e146-41ac-8958-6c3e5386cecc
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on URDF assembly component prefixes and naming policy
Fix Mar 26, 2026
add_sensor_attachments mixing link elements into joints list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add_sensor_attachmentswas appending<link>elements into thejointslist, which would cause link elements to be emitted in the joint section of the assembled URDF.Changes
connection.py—add_sensor_attachments: Added alinks: listparameter; sensor<link>elements now append tolinks, while<joint>elements (from the sensor URDF and the new attachment joint) continue to append tojoints.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.