Skip to content

Fix add_sensor_attachments mixing link elements into joints list#204

Draft
Copilot wants to merge 2 commits intocjt/modify_urdf_assemblyfrom
copilot/sub-pr-202-again
Draft

Fix add_sensor_attachments mixing link elements into joints list#204
Copilot wants to merge 2 commits intocjt/modify_urdf_assemblyfrom
copilot/sub-pr-202-again

Conversation

Copy link
Contributor

Copilot AI commented Mar 26, 2026

add_sensor_attachments was appending <link> elements into the joints list, which would cause link elements to be emitted in the joint section of the assembled URDF.

Changes

  • connection.pyadd_sensor_attachments: Added a links: list parameter; sensor <link> elements now append to links, while <joint> elements (from the sensor URDF and the new attachment joint) continue to append to joints.
# Before
def add_sensor_attachments(self, joints: list, attach_dict: dict, base_points: dict):
    ...
    joints.append(link)  # bug: link element in joints list

# After
def add_sensor_attachments(self, links: list, joints: list, attach_dict: dict, base_points: dict):
    ...
    links.append(link)   # link elements go to links
    joints.append(joint) # joint elements go to joints

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] [WIP] Address feedback on URDF assembly component prefixes and naming policy Fix add_sensor_attachments mixing link elements into joints list Mar 26, 2026
Copilot AI requested a review from chase6305 March 26, 2026 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants