Skip to content

Fix gizmo fault#211

Merged
yuecideng merged 1 commit intoDexForce:yueci/adapt-dexsim040from
WaferLi:yueci/adapt-dexsim040
Mar 31, 2026
Merged

Fix gizmo fault#211
yuecideng merged 1 commit intoDexForce:yueci/adapt-dexsim040from
WaferLi:yueci/adapt-dexsim040

Conversation

@WaferLi
Copy link
Copy Markdown
Collaborator

@WaferLi WaferLi commented Mar 31, 2026

Description

This PR fixes a bug in the Gizmo Python bindings where setting the local pose callback would incorrectly overwrite the transform flush callback, and ensures data is correctly formatted before being passed to the user.

Summary of changes:

  • Fixed Callback Conflict: Resolved an issue where set_flush_localpose_callback and set_transform_flush_callback were conflicting with each other, ensuring they can be used independently as intended.
  • Improved Data Formatting: Corrected the logic for set_transform_flush_callback to properly decompose the transformation matrix into human-readable Position and RPY (Roll-Pitch-Yaw) vectors for the Python callback.
  • Logic Validation: Ensured that set_flush_localpose_callback correctly receives and processes the local pose matrix without interference.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which improves an existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (existing functionality will not work without user modification)
  • Documentation update

Checklist

  • I have run the black . command to format the code base.
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Dependencies have been updated, if applicable.

@yuecideng yuecideng merged commit b0d9579 into DexForce:yueci/adapt-dexsim040 Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants