Fix gizmo fault#211
Merged
yuecideng merged 1 commit intoDexForce:yueci/adapt-dexsim040from Mar 31, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in the Gizmo Python bindings where setting the local pose callback would incorrectly overwrite the transform flush callback, and ensures data is correctly formatted before being passed to the user.
Summary of changes:
set_flush_localpose_callbackandset_transform_flush_callbackwere conflicting with each other, ensuring they can be used independently as intended.set_transform_flush_callbackto properly decompose the transformation matrix into human-readable Position and RPY (Roll-Pitch-Yaw) vectors for the Python callback.set_flush_localpose_callbackcorrectly receives and processes the local pose matrix without interference.Type of change
Checklist
black .command to format the code base.