Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
1. Gizmo Callback API Enhancement (C++ & Python Binding)
set_flush_localpose_callbackwhich supports direct 4x4 matrix (local_pose) input.translationandrotationhandling into a unified pose synchronization, reducing data transformation overhead between C++ and Python.2. Logic Simplification & Utility Update (
gizmo_utils.py)create_gizmo_callbackto support the new API.if flag == TransformMask...conditional branches with a singlenode.set_transform(local_pose, flag)call, making the callback significantly more concise and readable.3. Bug Fix in Example Code (
gizmo_object.py)UnboundLocalErrorin therun_simulationfunction.gizmo_enabled = Truewithin the function scope to ensure the logic atstep_count == 200000executes correctly without crashing.Type of Change
Checklist
black .command to format the code base.