Add multi-asset loading with spacing in preview script#224
Merged
Conversation
Allow --asset_path to accept multiple assets and add --asset_spacing\nfor 1m-relative placement between loaded assets.\n\nAlso update preview/main flow to handle a list of loaded\nassets and improve UID handling for multi-asset loads.\n\nCo-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for loading multiple assets in the preview_asset.py script by allowing multiple --asset_path values and spacing each asset along +X from the initial position.
Changes:
- Rename single-asset loader to
load_assets()and return a list of loaded assets. - Add
--asset_spacingCLI argument and place assets atinit_pos + (idx * spacing, 0, 0). - Update preview/main flow to work with multiple loaded assets.
Comments suppressed due to low confidence (1)
embodichain/lab/scripts/preview_asset.py:76
- The load_assets() docstring claims that when
--asset_typeis not specified and the file is USD, the script will inspect the USD stage to auto-select between articulation vs rigid. In the current implementationasset_typeis always taken fromargs.asset_type(defaulting to "rigid") except for the URDF override, so no USD auto-detection occurs. Please either implement the described USD inspection (likely requiring--asset_typedefaulting to None so you can detect whether the user provided it) or update the docstring/CLI help to reflect the actual behavior.
If ``--asset_type`` is not specified and the file is USD, the script will
inspect the USD stage for articulation roots to decide between articulation
and rigid object. For non-USD files the default is always ``rigid``.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yuecideng
added a commit
that referenced
this pull request
Apr 10, 2026
chase6305
pushed a commit
that referenced
this pull request
Apr 16, 2026
yangchen73
pushed a commit
that referenced
this pull request
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds multi-asset support to the asset preview script.
It allows passing multiple paths to --asset_path and loads each asset with configurable relative spacing (default 1.0m) along +X from the provided initial position.
Dependencies: None
Fixes #
Type of change
Screenshots
N/A
Checklist
black .command to format the code base.🤖 Generated with Claude Code