Skip to content

hotfix - getting rid of sudos#16

Merged
RobertLucian merged 12 commits intoDexterInd:masterfrom
RobertLucian:hotfix/installer-privileges
Dec 21, 2017
Merged

hotfix - getting rid of sudos#16
RobertLucian merged 12 commits intoDexterInd:masterfrom
RobertLucian:hotfix/installer-privileges

Conversation

@RobertLucian
Copy link
Copy Markdown
Contributor

By doing this, we can install the script_tools repo/package with the right privileges as specified by the install command.

# with root privileges
sudo sh -c "curl -kL dexterindustries.com/update_tools | bash"
# with user privileges
curl -kL dexterindustries.com/update_tools | bash

Comment thread functions_library.sh
if [ -z ${1+x} ]; then
echo "Working from main branch.";
else
# -z tests for zero length.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the love of all holy, please, turn off your white space editing.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a big deal, but it makes reviewing edits a lot easier.

Copy link
Copy Markdown
Contributor Author

@RobertLucian RobertLucian Dec 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no mods on the functions_library.sh file, so I can't see what you're seeing.

Second, I don't have any white space editing option thing going on my editor. I don't do space-editing, I always prefer tabs, and frankly, that's done automatically.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to have disappeared.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did yesterday night a reverse-commit so maybe you were seeing the old mods.

@johnisanerd
Copy link
Copy Markdown
Collaborator

@RobertLucian have you tested this on DexterOS yet?

@johnisanerd johnisanerd requested a review from CleoQc December 14, 2017 07:46
@RobertLucian
Copy link
Copy Markdown
Contributor Author

I have tested it on my version of DexterOS and partly on Raspbian For Robots. I'll be doing more tests anyway, because I have to bring changes to all repos.

@CleoQc
Copy link
Copy Markdown
Member

CleoQc commented Dec 15, 2017

Just so you know, historically speaking, the Pi required sudo for a lot of stuff, accessing the pins for example. That's why there are sudos all over the place.

Copy link
Copy Markdown
Collaborator

@johnisanerd johnisanerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave it a test on DexterOS, R4R, and Stretch and each seemed to work ok.

Copy link
Copy Markdown
Member

@CleoQc CleoQc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on DexterOS and Raspbian.
Only tested GoPiGo3 platform though.

@RobertLucian RobertLucian merged commit 531fc63 into DexterInd:master Dec 21, 2017
@RobertLucian RobertLucian deleted the hotfix/installer-privileges branch December 21, 2017 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants