Rework digital media page#33
Merged
TomDijkema merged 7 commits intomainfrom Jun 8, 2023
Merged
Conversation
Commit reworks the Digital Media Page. Brings the concept back to the basics first: showing off the digital media of the given id, and mentioning the related ones. Other functionality like digital media annotations and the visual annotations have been removed until future implementation. Modifies: - Digital Media Page, now includes ID Card, horizontal slider and scaled images to their relative size Removes (until future development): - Digital Media Annotations Modal - Observation modal with visual annotations
Commit generalises the Version Select Component and applies it also to the Digital Media page for future versioning (when the API also supports it). The usage of the component on the Specimen Page needed to be changed due to the generalisation. Adds: - Versioning to the Digital Media Page Modifies: - Version Select Component to be generally usable
Commit (hopefully) resolves the sizing issue with the Homepage on smaller screens.
Commit adds generic Tooltip component for adding Tooltips. Makes use of the Bootstrap components, and combines them into a custom component that accepts HTML children. Adds: - Custom Tooltip Component
Commit to resolve Sonar Cloud issues
Commit includes a dynamic API url based upon the current path of the application. This means the API will always share the same core route!
Second commit for resolving Sonar Cloud issues
|
Kudos, SonarCloud Quality Gate passed! |
samleeflang
reviewed
Jun 8, 2023
Contributor
samleeflang
left a comment
samleeflang
left a comment
There was a problem hiding this comment.
Small comments. Looks good, nice that the tooltip is also in here
samleeflang
approved these changes
Jun 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR reworks the Digital Media Page. Brings the concept back to the basics first: showing off the digital media of the given id, and mentioning the related ones. Other functionality like digital media annotations and the visual annotations have been removed until future implementation. Also includes versioning for Digital Media (when supported by API), and a custom Tooltip component.
Adds:
Modifies:
Removes (until future development):