Feature #33472710#5
Merged
TomDijkema merged 11 commits intomainfrom Sep 26, 2022
Merged
Conversation
Commit adds basic login functionality with the Keycloak library. Adds: - Keycloak package - Seperate Keycloak section (files) - Login functionality from header
Commit adds all or most of the requested functionality for the basic image of the Unified Curation and Annotation System. Adds: - Improved login functionality with Keycloak / token integration for full integration - Specimen page: details / media gallery / mids bar / version tabs - Annotation and Curation page: - Specimen bar with name, specimen type and the option to switch to annotate or curate mode - MIDS details block that contains all indications for improving the digital specimen based upon the MIDS documentation - MIDS meter (non-functional yet) - Annotation section with all the properties of a digital specimen those can be annotated - Annotation modal which allows the user to see, add, edit and remove annotations (the latter three only if the user is logged in) - A JSON filter layer for detailing the property information with a: display name, mids level, annotatable boolean and possible rules (for arrays, dates, images, etc.) - Dockerfile - Kubernetes files - NGINX configuration Updates: - The general code concept of the project (REACT) - Styling of existing pages Removes: - The old method of processing the digital specimen (and using its properties) - Old media gallery
Commit to end this branch of huge commits and go back to the more simplistic form of small commits. This commit contains a somewhat stable version of the UCAS system, based upon the changes made to the API. Adds: - Specimen version reckoning - Improved filter layer - Improved styling Modifies: - API interactions based upon changes in the API - Media being loaded after the main specimen data - Alters homepage a bit, but has to be improved - Improved Header and Footer Removes: -
Adds: - Support for the new endpoints of sandbox.dissco.tech/annotations - Basic navigation in header Modifies: - Styling for home, search pages - Fix scrolling mechanism when clicking on MIDS property on Annotation page
Commit fixes the version switching between specimens. Using the dropdown, users can now instantaneously switch between versions
Commit is the first step for moving the Annotation Page Components to the main Specimen Page because these functionalities will now be executed from the same page. This first step moves the visual components, updates the modal and secures the scroll functionality for mids. Modifies: - Moves Components and functionality from the Annotation Page to the Specimen Page
Adds: - New way of handling annotations in the view. Annotations will now be handled by their respective attribute and thus shall only be shown when a modal of specific attribute is opened. - Attributes know show a pencil icon on the overview page when annotations are present. Modifies: - Homepage styling: add new banner based upon five images. Work has to be continued on the dynamic parts when API is ready. Removes: - Old banner (still present in code but not used)
Commit fixes Media Slider bug not showing all images. Issue was due to some formats not being accepted, as well as some images that were hidden due to incorrect styling.
First commit for fixing SonarCloud issues.
Second commit for fixing SonarCloud issues
|
Kudos, SonarCloud Quality Gate passed!
|
samleeflang
reviewed
Sep 23, 2022
Contributor
samleeflang
left a comment
samleeflang
left a comment
There was a problem hiding this comment.
Tom echt netjes! Veel werk verzet en het ziet er al veel beter uit dan eerst. De code is goed leesbaar doordat de files klein zijn en de functionaliteit per file beperkt is. Complimenten. Het enige wat misschien beter kan is de hoeveelheid CSS. Misschien kunnen we bekijken of we generieke componenten kunnen maken of dat we componenten uit frameworks kunnen gebruiken.
samleeflang
approved these changes
Sep 26, 2022
Contributor
samleeflang
left a comment
samleeflang
left a comment
There was a problem hiding this comment.
Comment looked at and things that needed to be done ar done. Some things will go into next PR or the backlog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request to maintain a (kinda) stable version of the UCAS system (changes could be made based upon changes in the API).
Goal of this stable version is to get rid of the big commits and go back to the form of the small commits about specific parts.