Issue 665 feature #684
Open
Issue 665 feature #684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix some PMD issues
This reverts commit fad0fd0.
1_Comments for the added method. 2_Generalize test by using random sized input lists with random integers. 3_Check that the subset list elements are wholly contained in the input list
Fix PMD issues for issue 665
1_Used Random.nextInt instead of Math.random and converting to an int in getRandomSubset 2_Used Random.nextInt instead of Math.random and converting to an int in testRandomSubset1 3_Minor clean-up in testRandomSubset1
This reverts commit dcd1cf8.
This reverts commit 5b77134.
This reverts commit dcd1cf8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement issue, add tests and make sure the static analysis tools PMD and Spot Bugs are clean for the changes