Merged
Conversation
Use configurable temp path to fix permission errors on Docker - Replace hardcoded '/tmp' with tempPathManager.getTempBasePath() across all yt-dlp spawn calls (channelModule, downloadExecutor, ytDlpRunner, ytdlpModule, videoDownloadPostProcessFiles) - Add --paths temp: argument to yt-dlp commands via new buildTempPathArgs() method, redirecting yt-dlp's internal temp files to writable staging directory - Use lazy loading for tempPathManager in ytdlpModule to avoid circular deps - Update tests to mock tempPathManager and verify TMPDIR is set correctly
- Add explicit instruction to only use gh commands in review prompt - Prohibit running tests, npm commands, or other shell commands - Remove misleading "branch is already checked out" text that encouraged local command execution
Contributor
📊 Test Coverage ReportBackend Coverage
Frontend Coverage
Coverage Requirements
Coverage report generated for commit 185ff04 |
Collaborator
Author
|
@claude Please review this PR, do not attempt to run tests, just review the code |
|
Claude encountered an error —— View job Code Review
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use configurable temp path to fix permission errors on Docker