Skip to content

LIMS-2077: Individual grid scans show boxes for group of grid scans#1041

Merged
ndg63276 merged 1 commit intopre-release/2026-R2.1from
fix/LIMS-2077/individual-grid-scans-show-3d-boxes
Mar 24, 2026
Merged

LIMS-2077: Individual grid scans show boxes for group of grid scans#1041
ndg63276 merged 1 commit intopre-release/2026-R2.1from
fix/LIMS-2077/individual-grid-scans-show-3d-boxes

Conversation

@ndg63276
Copy link
Copy Markdown
Collaborator

@ndg63276 ndg63276 commented Mar 2, 2026

JIRA ticket: LIMS-2077

Summary:

Groups of grid scans for Xray centring correctly show the number of boxes in 3 dimensions on the main page, but when you click into the group, it should show the individual grid scans with the 2d number of boxes.

Changes:

  • Put the 3rd dimension of the grid scan group (STEPS_Z) into a separate span
  • Hide the span if viewing inside a data collection group

To test:

  • Go to a visit with grid scan groups eg /dc/visit/cm40608-5
  • Check the groups of grid scans on the main page show 3 dimensions for Grid Scan Size, eg 30 x 10 x 15
  • Click into one of the groups eg /dc/visit/cm40608-5/dcg/17214375
  • Check each grid scan only shows 2 dimensions eg 30 x 10 or 30 x 15
  • Click into an individual grid scan eg /dc/visit/cm40608-5/id/20910753
  • Check it only shows 2 dimensions again eg 30 x 10

@gfrn
Copy link
Copy Markdown
Collaborator

gfrn commented Mar 6, 2026

I seem to get a Uncaught TypeError: totalRecords must be a finite integer on /dc/visit/cm40608-5, is that intended?

@ndg63276
Copy link
Copy Markdown
Collaborator Author

ndg63276 commented Mar 6, 2026

I seem to get a Uncaught TypeError: totalRecords must be a finite integer on /dc/visit/cm40608-5, is that intended?

Hmmm... not deliberate, and possibly unrelated to this change. Is it reproducible? And does it give a filename and line number?

@gfrn
Copy link
Copy Markdown
Collaborator

gfrn commented Mar 9, 2026

Line 45 in /client/src/js/collections/datacollections.js, but it seems to have solved itself when the database was restored over the weekend... Maybe there were a few missing records?

@ndg63276
Copy link
Copy Markdown
Collaborator Author

ndg63276 commented Mar 9, 2026

Yeah probably. Certainly not related to the changes in this PR.

@ndg63276 ndg63276 changed the base branch from master to pre-release/2026-R2.1 March 24, 2026 10:16
@ndg63276 ndg63276 merged commit fbe63e1 into pre-release/2026-R2.1 Mar 24, 2026
2 checks passed
@ndg63276 ndg63276 deleted the fix/LIMS-2077/individual-grid-scans-show-3d-boxes branch March 24, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants