LIMS-2120: Hide courier fields if using facility account#1050
Merged
ndg63276 merged 2 commits intopre-release/2026-R2.2from Apr 7, 2026
Merged
Conversation
gfrn
approved these changes
Apr 2, 2026
ndg63276
added a commit
that referenced
this pull request
Apr 20, 2026
* LIMS-2125: Allow use of shipping service for EU dispatches (#1049) * LIMS-2033: Fix count of autoprocessing errors (#1047) * LIMS-2037: Remove manual check for duplicate acronyms (#1034) * LIMS-2120: Hide courier fields if using facility account (#1050) * LIMS-2141: Suppress errors if visit directory has been replaced with a file (#1051) * I02-1 has 3 webcams --------- Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-2120
Summary:
When making a shipment, we should detect if the lab contact is in the UK, and academic. Then we can present the button to say "Use Facility Account", and if they do, we can hide all the courier fields.
Changes:
To test:
$facility_courier_countries_nde), and one is non-EU