LIMS-1949: Use parentAutoProcProgramId field#1062
Merged
ndg63276 merged 2 commits intopre-release/2026-R2.3from Apr 21, 2026
Merged
LIMS-1949: Use parentAutoProcProgramId field#1062ndg63276 merged 2 commits intopre-release/2026-R2.3from
ndg63276 merged 2 commits intopre-release/2026-R2.3from
Conversation
Collaborator
|
When I set |
Collaborator
Author
|
Yeah it is a bit of a weird test, when we put a realistic number it should behave more normally. |
gfrn
approved these changes
Apr 20, 2026
ndg63276
added a commit
that referenced
this pull request
May 1, 2026
* Add instruction for industry users (#1063) * LIMS-1949: Use parentAutoProcProgramId field (#1062) * LIMS-1949: Use parentAutoProcProgramId field * LIMS-1949: Add config variable to example file --------- Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk> * LIMS-2109: Require an email address when creating a plate (#1037) * LIMS-2109: Require an email address when creating a plate * Update php-jwt as much as possible and ignore security advisory --------- Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk> * LIMS-2126: Add new strategy pipeline and tidy code (#1054) Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk> * LIMS-2135: Update PHP Libraries (#1053) * LIMS-2135: Update PHP Libraries * LIMS-2135: Update tests for PHP 7.4.33 * LIMS-2135: Use global getallheaders * LIMS-2135: Fix unit tests * LIMS-2135: Fix unit tests * LIMS-2135: Add bootstrap getallheaders function for CI tests --------- Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk> * LIMS-2136: Fix editing priority processing pipeline (#1057) Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk> * LIMS-2139: Dont display special beam as beam dumps (#1052) Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk> * LIMS-2163: Notation change to dispensing CSV for 2 drop plates --------- Co-authored-by: Guilherme Francisco <guilherme.de-freitas@diamond.ac.uk> Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-1949
Summary:
It is useful to be able to see a downstream processing job's upstream parent, but at the moment we use the "scaling_id" parameter in the ProcessingJobParameter table, which is a bit flaky. We now have an
AutoProcProgram.parentAutoProcProgramIdfield, which is being populated from about 1st April 2026.Changes:
_lookup_autoprocto a new_lookup_parent_autoprocfunction, which uses the parentAutoProcProgramId fieldTo test: