Skip to content

LIMS-1949: Use parentAutoProcProgramId field#1062

Merged
ndg63276 merged 2 commits intopre-release/2026-R2.3from
improvement/LIMS-1949/use-parentautoprocprogramid-field
Apr 21, 2026
Merged

LIMS-1949: Use parentAutoProcProgramId field#1062
ndg63276 merged 2 commits intopre-release/2026-R2.3from
improvement/LIMS-1949/use-parentautoprocprogramid-field

Conversation

@ndg63276
Copy link
Copy Markdown
Collaborator

@ndg63276 ndg63276 commented Apr 15, 2026

JIRA ticket: LIMS-1949

Summary:

It is useful to be able to see a downstream processing job's upstream parent, but at the moment we use the "scaling_id" parameter in the ProcessingJobParameter table, which is a bit flaky. We now have an AutoProcProgram.parentAutoProcProgramId field, which is being populated from about 1st April 2026.

Changes:

  • Re-route all calls to _lookup_autoproc to a new _lookup_parent_autoproc function, which uses the parentAutoProcProgramId field
  • If no parent job is found, fall back to the old method, to avoid all pre-April 2026 jobs being broken
  • Use a config variable to limit falling back to before a certain job, as from now on the parentAutoProcProgramId field should be populated
  • Simplify the old method a little, Big EP was using the program_id instead of the scaling_id, but this seems not to be necessary

To test:

  • Go to a recent data collection with lots of downstream processing jobs, eg /dc/visit/nt44198-3/id/22397399
  • On each downstream job, click the "View Upstream" button, check it opens the Automatic Processing bar if needed and switches to the correct tab
  • Go to an older data collection eg /dc/visit/nt44198-3/id/21167691, repeat the check
  • Add the config variable with a low number eg
$max_appid_without_parent = 123;
  • Repeat the check on the older data collection, it should stop working as you have now disallowed falling back to the old method
  • Now set it to 119440000, and repeat the check on the older data collection, it should work again.

@gfrn
Copy link
Copy Markdown
Collaborator

gfrn commented Apr 20, 2026

When I set $max_appid_without_parent to 123, it does stop working, but silently, it still opens the accordion and sets the tab to autoPROC, will this be a problem? I assume in prod, we'll just set to a realistic value anyway

@ndg63276
Copy link
Copy Markdown
Collaborator Author

Yeah it is a bit of a weird test, when we put a realistic number it should behave more normally.

@ndg63276 ndg63276 changed the base branch from master to pre-release/2026-R2.3 April 21, 2026 08:54
@ndg63276 ndg63276 merged commit 06d301b into pre-release/2026-R2.3 Apr 21, 2026
2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-1949/use-parentautoprocprogramid-field branch April 21, 2026 08:55
ndg63276 added a commit that referenced this pull request May 1, 2026
* Add instruction for industry users (#1063)

* LIMS-1949: Use parentAutoProcProgramId field (#1062)

* LIMS-1949: Use parentAutoProcProgramId field

* LIMS-1949: Add config variable to example file

---------

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

* LIMS-2109: Require an email address when creating a plate (#1037)

* LIMS-2109: Require an email address when creating a plate

* Update php-jwt as much as possible and ignore security advisory

---------

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

* LIMS-2126: Add new strategy pipeline and tidy code (#1054)

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

* LIMS-2135: Update PHP Libraries (#1053)

* LIMS-2135: Update PHP Libraries

* LIMS-2135: Update tests for PHP 7.4.33

* LIMS-2135: Use global getallheaders

* LIMS-2135: Fix unit tests

* LIMS-2135: Fix unit tests

* LIMS-2135: Add bootstrap getallheaders function for CI tests

---------

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

* LIMS-2136: Fix editing priority processing pipeline (#1057)

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

* LIMS-2139: Dont display special beam as beam dumps (#1052)

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

* LIMS-2163: Notation change to dispensing CSV for 2 drop plates

---------

Co-authored-by: Guilherme Francisco <guilherme.de-freitas@diamond.ac.uk>
Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants