LIMS-2181: Improve speed of queueing and editing 1000s of samples#1070
Merged
ndg63276 merged 5 commits intoMay 18, 2026
Merged
Conversation
gfrn
reviewed
May 18, 2026
| SET requiredresolution=:1, experimentkind=:2, preferredbeamsizex=:3, preferredbeamsizey=:4, | ||
| exposuretime=:5, boxsizex=:6, boxsizey=:7, axisstart=:8, axisrange=:9, | ||
| numberofimages=:10, transmission=:11, energy=:12, monochromator=:13 | ||
| WHERE diffractionplanid IN ($id_list)", $set_args); |
Collaborator
There was a problem hiding this comment.
Would it be better to do something like in like 663, using placeholders instead of dropping the IDs directly into the query? Just so we avoid adding any possible avenues for SQL injection
gfrn
reviewed
May 18, 2026
Co-authored-by: Guilherme Francisco <guilherme.de-freitas@diamond.ac.uk>
Collaborator
|
Switching between pages is somewhat slow for me, but everything else works! LGTM |
gfrn
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-2181
Summary:
As we now automatically detect crystals in plates, there can be 1000s of them, that all need queueing, and also parameters adding to. This is currently very slow as it loops through each subsample individually. This change is to make the "Add All to Queue" and "Apply to All" buttons use far fewer database calls.
Changes:
To test: