LIMS-216: Fix message for industrial archived visits#440
Merged
NKatti2011 merged 4 commits intoDiamondLightSource:prereleasefrom Feb 23, 2023
ndg63276:fix/LIMS-216/fix-message-for-industrial-archived-visits
Merged
LIMS-216: Fix message for industrial archived visits#440NKatti2011 merged 4 commits intoDiamondLightSource:prereleasefrom ndg63276:fix/LIMS-216/fix-message-for-industrial-archived-visits
NKatti2011 merged 4 commits intoDiamondLightSource:prereleasefrom
ndg63276:fix/LIMS-216/fix-message-for-industrial-archived-visits
Conversation
KarlLevik
reviewed
Feb 3, 2023
Member
KarlLevik
left a comment
KarlLevik
left a comment
There was a problem hiding this comment.
It seems to be giving identical messages, whether it's an IN visit or not?
I believe that last message should not say the visit is archived?
Collaborator
Author
|
All visits are archived, but the difference is whether the data within that visit is archived or deleted. |
Member
Hmm, that sounds confusing. What does it mean for a visit to be archive without its data? Perhaps better for the message then to say whether the visit data has been archived or not. |
KarlLevik
approved these changes
Feb 8, 2023
Member
KarlLevik
left a comment
KarlLevik
left a comment
There was a problem hiding this comment.
The messages are now spot on!
I have no idea about the HTML, but presumably it works!
Collaborator
|
Reopen pull request. |
Collaborator
|
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: LIMS-216
Clarify that data from 'archived' industrial visits is deleted, not archived.