[LIMS-413]Improvement: Make dynamic editable#473
Merged
NKatti2011 merged 2 commits intoprereleasefrom Feb 23, 2023
Merged
Conversation
NKatti2011
reviewed
Feb 22, 2023
| $dynamic = $this->has_arg("DYNAMIC") ? $this->arg("DYNAMIC") : null; | ||
| $dynamic = null; | ||
| if ($this->has_arg('DYNAMIC')){ | ||
| $dynamic = $this->arg("DYNAMIC") ? "Yes" : "No"; |
Collaborator
There was a problem hiding this comment.
If Dynamic == No, how will it be assigned? With yes?
Contributor
Author
There was a problem hiding this comment.
It seems that shipments can't be created with 'Yes'/'No', but can be updated with 'Yes'/'No' - which is strange. This is not an issue when going through the front-end, but does make the 'API' less sensible. Since this problem also applies to MICROFOCUSBEAM, LASTMINUTEBEAMTIME etc., perhaps fixing this should be a seperate ticket?
Collaborator
There was a problem hiding this comment.
Since its not relevant to updating we can leave this as is.
Collaborator
|
LGTM |
NKatti2011
pushed a commit
that referenced
this pull request
Feb 23, 2023
* LIMS-413: Make 'dynamic' editable on shipment page * LIMS-413: Fix conversion of DYNAMIC to Yes/No
John-Holt-Tessella
deleted the
improvement/LIMS-413/make-dynamic-changable
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-413
Changes:
DYNAMICto be changed via the shipment page - i.e. allow users to change 'responsive remote' after a shipment has been created.DYNAMICto be a string'Yes'/'No'rather than a boolean.REMOTEORMAILIN,SESSIONLENGTH,ENERGY,MICROFOCUSBEAM,SCHEDULINGRESTRICTIONS,LASTMINUTEBEAMTIME,DEWARGROUPING) to be shown/hidden when the value ofDYNAMICis changed on the shipment page.To test:
DYNAMICand the remote options can be edited via the shipment page.