Lims 421/bug/insert lab info#477
Merged
John-Holt-Tessella merged 3 commits intopre-release/2022-R4.3-PHP-upgradefrom Feb 20, 2023
Merged
Lims 421/bug/insert lab info#477John-Holt-Tessella merged 3 commits intopre-release/2022-R4.3-PHP-upgradefrom
John-Holt-Tessella merged 3 commits intopre-release/2022-R4.3-PHP-upgradefrom
Conversation
John-Holt-Tessella
changed the base branch from
pre-release/2022-R4.3-PHP-upgrade
to
master
John-Holt-Tessella
changed the base branch from
master
to
pre-release/2022-R4.3-PHP-upgrade
Contributor
Author
MattPrit
approved these changes
Feb 20, 2023
Contributor
MattPrit
left a comment
MattPrit
left a comment
There was a problem hiding this comment.
Looks good to me overall
MattPrit
approved these changes
Feb 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a lab record does not exist and then a value is inserted the previous code failed. This now works because it only updates the values which it has to set