Skip to content

[LIMS-475]Fix: Persist SCHEDULINGRESTRICTIONS to database#480

Merged
NKatti2011 merged 1 commit intoprereleasefrom
fix/LIMS-475/persist-scheduling-restrictions-to-ispyb
Feb 23, 2023
Merged

[LIMS-475]Fix: Persist SCHEDULINGRESTRICTIONS to database#480
NKatti2011 merged 1 commit intoprereleasefrom
fix/LIMS-475/persist-scheduling-restrictions-to-ispyb

Conversation

@MattPrit
Copy link
Contributor

@MattPrit MattPrit commented Feb 23, 2023

JIRA ticket: LIMS-475

Changes:

  • Assign SCHEDULINGRESTRICTIONS to the $scheduling_restrictions vaiable

To test:

  • Check that, when a 'dynamic' shipment is created with scheduling restrictions specified, the scheduling restrictions are persisted to the database.

ndg63276
ndg63276 reviewed Feb 23, 2023
View reviewed changes
Copy link
Collaborator

@ndg63276 ndg63276 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working

@NKatti2011
Copy link
Collaborator

NKatti2011 commented Feb 23, 2023

LGTM

@NKatti2011 NKatti2011 merged commit 6f3a4a5 into prerelease Feb 23, 2023
@John-Holt-Tessella John-Holt-Tessella deleted the fix/LIMS-475/persist-scheduling-restrictions-to-ispyb branch June 13, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndg63276 ndg63276 ndg63276 left review comments

@NKatti2011 NKatti2011 Awaiting requested review from NKatti2011

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MattPrit @NKatti2011 @ndg63276