LIMS-464: Add config variable to allow ending of grid scan image scaling#484
Merged
MattPrit merged 2 commits intoprereleasefrom Mar 7, 2023
Merged
Conversation
* Requires new variable in config.php, formatted as eg: $scale_grid_end_date = 20221231; * This should be added as/when GDA fix the grid scan scaling on affected beamlines (listed as $scale_grid) * If $scale_grid_end_date is not present, image scaling will continue as before
MattPrit
approved these changes
Mar 7, 2023
Contributor
MattPrit
left a comment
MattPrit
left a comment
There was a problem hiding this comment.
LGTM. @NKatti2011 approves
John-Holt-Tessella
deleted the
improvement/LIMS-464/allow-grid-scan-image-scaling-to-end
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: LIMS-464
Requires new variable in config.php, formatted as eg:
$scale_grid_end_date = 20221231;
This should be added as/when GDA fix the grid scan scaling on affected beamlines (listed as $scale_grid)
If $scale_grid_end_date is not present, image scaling will continue as before