Use facility_email rather than dispatch_email as shipper_contact_email#514
Merged
John-Holt-Tessella merged 1 commit intoprereleasefrom Apr 17, 2023
Conversation
John-Holt-Tessella
approved these changes
Mar 31, 2023
John-Holt-Tessella
changed the base branch from
pre-release/2023-R1.11
to
prerelease
John-Holt-Tessella
deleted the
fix/fix-shipper-email-in-shipping-service-request
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
$facility_emailrather than$dispatch_emailasshipper_contact_emailwhen making shipping service requests. this is because the shipping service expects only a single email address, whereas$dispatch_emailcan be a list of email addresses. Also, the facility email address is a more sensible email to be used as the shipper contact email from DHL's point of view.To test:
$dispatch_emailis a list of emails.