Skip to content

LIMS-996: Trim empty space around courier name#664

Merged
ndg63276 merged 1 commit intoprereleasefrom
fix/LIMS-996/trim-empty-space-around-courier-name
Nov 16, 2023
Merged

LIMS-996: Trim empty space around courier name#664
ndg63276 merged 1 commit intoprereleasefrom
fix/LIMS-996/trim-empty-space-around-courier-name

Conversation

@ndg63276
Copy link
Collaborator

Ticket: LIMS-996

Changes:

  • Trim courier name before comparing to 'dhl', otherwise couriers like ' dhl' and 'dhl ' will be rejected.

Tests:

  • Go to a test shipment eg on mx23694, edit courier name to 'DHL', check 'Create Air Waybill' button remains after refresh
  • Edit courier name to ' DHL', check button remains after refresh
  • Edit courier name to 'Fedex', check button has gone after refresh

@ndg63276 ndg63276 requested a review from MattPrit September 14, 2023 14:19
@ndg63276 ndg63276 merged commit f15e57a into prerelease Nov 16, 2023
@ndg63276 ndg63276 deleted the fix/LIMS-996/trim-empty-space-around-courier-name branch November 16, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants