LIMS-697: Use more specific PVs for puck names#712
Merged
ndg63276 merged 4 commits intoprereleasefrom Feb 5, 2024
Merged
Conversation
gfrn
approved these changes
Feb 5, 2024
Collaborator
There was a problem hiding this comment.
I think the way PV searches are done (build PV name array, then mass caget, and reindex, searching for the returned PVs in the initial array) feels a bit off, but I cannot say with absolute certainty it can be refactored without affecting other bits of code elsewhere.
Also, long shot, but EPICS exposes EPICS_BASE and EPICS_HOST_ARCH, so if we really wanted to, we could also build the path from these environment variables rather than from a path to caget in config.php, but that's minimal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Github issue: #53
JIRA ticket: LIMS-697
Summary:
@jlmuir points out that not all facilities have a one-to-one mapping of beamlines to pv prefixes (DLS included). As the
$bl_pv_mapvariable is only used in one place, we should replace it with a template for the specific PVs it is used for.Changes:
$bl_pv_mapvariable$bl_puck_namesvariable for a template for the puck names PVTo test: