LIMS-1202: Fix UAS filter and table sorting on Phases/Proteins page#724
Merged
ndg63276 merged 1 commit intoprereleasefrom Feb 26, 2024
Merged
Conversation
gfrn
reviewed
Feb 26, 2024
gfrn
approved these changes
Feb 26, 2024
gfrn
pushed a commit
that referenced
this pull request
Mar 5, 2024
…724) Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-1202
Summary:
On an xpdf proposal, on the Phases page, there is a tickbox to "Show Only UAS Samples". This has the effect of grouping phases by their external id, so only one entry appears for each UAS sample, but as they are ordered by most recent, the recent non-UAS phases are shown instead of older UAS phases.
Sorting on the same table only worked for a couple of columns as well.
Changes:
To test: