LIMS-303: Show visits from other villages on user calendar#725
Merged
ndg63276 merged 1 commit intoprereleasefrom Feb 13, 2024
Merged
Conversation
Collaborator
|
Although the PR itself works, I have noticed that the calendar button in the navbar does not appear for anyone that isn't staff, as there is a |
Collaborator
Author
|
Yeah, was going to do that as part of LIMS-1207. Non-stafff can get to the calendar at the moment from the menu. |
gfrn
approved these changes
Feb 13, 2024
gfrn
pushed a commit
that referenced
this pull request
Mar 5, 2024
Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-303
Summary:
The Calendar view currently only shows visits from the same beamline 'type' as the active proposal. Users would like to be able to see their visits from all villages. Don't apply to staff as the visit list becomes unwieldy.
Also, the visit list is requested 3 times when the page is first loaded.
Changes:
mounted()functionTo test:
/api/proposal/visits