Skip to content

[LIMS-1288] SynchWeb link to PATo with undefined session#754

Merged
gfrn merged 2 commits intoprereleasefrom
fix/lims-1288/pato-redirect-url
Apr 15, 2024
Merged

[LIMS-1288] SynchWeb link to PATo with undefined session#754
gfrn merged 2 commits intoprereleasefrom
fix/lims-1288/pato-redirect-url

Conversation

@gfrn
Copy link
Collaborator

@gfrn gfrn commented Apr 10, 2024

JIRA ticket: LIMS-1288

Summary:

When visiting an EM DC page for a null session, currently, the proposal or visit are not properly included in the URL. This fixes this by only including the session in URL if the session is valid, and in case both the proposal/session are not available through a prop or the URL, the redirect points to PATo's home page.

Changes:

  • Add conditional checks to build the redirection URL dynamically, taking into consideration the session/proposal validity.

To test:

  • Visit an EM DC page pointing to a null session (/dc/visit/ic37826-null) and check that only the proposal is included in the redirect
  • Visit a regular EM DC page (/dc/visit/bi23047-119) and check that both the session number and proposal are included in the redirect

Co-authored-by: Mark W <24956497+ndg63276@users.noreply.github.com>
@gfrn gfrn merged commit 362848f into prerelease Apr 15, 2024
@gfrn gfrn deleted the fix/lims-1288/pato-redirect-url branch April 30, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants