Skip to content

LIMS-1514: Allow sorting of visit list#873

Merged
ndg63276 merged 4 commits intopre-release/2025-R2.2from
improvement/LIMS-1514/allow-sorting-of-visit-list
Mar 25, 2025
Merged

LIMS-1514: Allow sorting of visit list#873
ndg63276 merged 4 commits intopre-release/2025-R2.2from
improvement/LIMS-1514/allow-sorting-of-visit-list

Conversation

@ndg63276
Copy link
Collaborator

@ndg63276 ndg63276 commented Dec 3, 2024

JIRA ticket: LIMS-1514

Summary:

The list of visits for a proposal is not sortable.
NB This PR replaces #854 which was found to break the main /current page in testing.

Changes:

  • Combine the data collection count into the main db query so that it can be sorted on, if a proposal is specified
  • Remove the need for an enter press on searching for a visit number, but add a debounce
  • Make column headers actually be buttons so that the cursor becomes a pointer
  • Re-fetch the data with a sort parameter if a header is clicked (apart from "Dewars")
  • Re-fetch the data in the opposite direction if the same header is clicked again
  • Don't add a search parameter if the search box is empty
  • Allow searching by beamline name

To test:

  • Open a proposal with a bunch of visits eg mx34263, and go to the /visits page
  • Check you can sort by each header, in both directions, apart from "Dewars"
  • Check the number of Data Collections is the same as on prod
  • Search for a visit number, check only that visit number is displayed, check the debounce is working by looking at the requests sent
  • Search for a beamline (eg i03), check only visits for that beamline are displayed
  • Go to the 'Home' page (/current), check the page loads promptly

@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R2.2 March 25, 2025 15:52
@ndg63276 ndg63276 merged commit d6b86cb into pre-release/2025-R2.2 Mar 25, 2025
@ndg63276 ndg63276 deleted the improvement/LIMS-1514/allow-sorting-of-visit-list branch March 25, 2025 15:56
ndg63276 added a commit that referenced this pull request Apr 8, 2025
* LIMS-1632: Buttons to go to next & previous puck in dewar (#912)

* LIMS-1406: Don't allow the location to be changed during a dispatch request (#888)

* LIMS-867: Improve 'Add Lab Contact' page (#877)

* LIMS-148: Improve staff imaging dashboard (#914)

* LIMS-1514: Allow sorting of visit list (#873)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants