Skip to content

LIMS-1066: Autofill UDC visit on dispatch form #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ndg63276 merged 1 commit into from
Jan 13, 2025
Merged

LIMS-1066: Autofill UDC visit on dispatch form #881

ndg63276 merged 1 commit into from
Jan 13, 2025

Conversation

@ndg63276
Copy link
Collaborator

@ndg63276 ndg63276 commented Dec 13, 2024

JIRA ticket: LIMS-1066

Summary:

When you request a dewar dispatch, the visit is automatically selected if it is associated with the dewar. But for UDC visits, the visit is associated with the container, so the visit is not automatically selected. This PR is to fix that.

Changes:

  • Outer join Container to BLSession, and get a UDC visit if one exists
  • Auto-select that visit in the dropdown if a non-UDC visit is not found

To test:

  • Turn off the shipping service, or just use examples who haven't selected 'Use facility account'
  • Go to a UDC shipment, eg /shipments/sid/67174, click "Dispatch", check that the visit is selected in the dispatch form
  • Go to a non-UDC shipment, eg /shipments/sid/66694, click "Dispatch", check that the visit is selected in the dispatch form
  • Go to a shipment with no visit associated, eg /shipments/sid/65232, click "Dispatch", check no visit is selected

@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R1.1 January 13, 2025 11:32
@ndg63276 ndg63276 merged commit 4a1884b into pre-release/2025-R1.1 Jan 13, 2025
2 checks passed
ndg63276 added a commit that referenced this pull request Jan 24, 2025
@ndg63276 @gfrn
Merge pre-release/2025-R1.1 into master (#899)
4a10c81 
* LIMS-1540 - Remove references to summary pages/DB (#860)

* LIMS-1564 - Remove unused dependencies (#868)

* LIMS-1066: Autofill UDC visit on dispatch form (#881)

* LIMS-1528: Fix sorting on old summary page (#883)

* LIMS-1554: Add 'State' column to proposals list page (#865)

---------

Co-authored-by: Guilherme Francisco <guilherme.de-freitas@diamond.ac.uk>
Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>
@ndg63276 ndg63276 deleted the improvement/LIMS-1066/autofill-udc-visit-on-dispatch-form branch January 31, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gfrn gfrn gfrn approved these changes

Assignees

No one assigned

Labels

Ready to Release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ndg63276 @gfrn