LIMS-1590: Dont allow name editing for lab contacts when login is set#887
Merged
ndg63276 merged 1 commit intopre-release/2025-R1.2from Jan 28, 2025
Conversation
gfrn
approved these changes
Jan 9, 2025
ndg63276
deleted the
improvement/LIMS-1590/make-name-uneditable-when-has-login
branch
ndg63276
added a commit
that referenced
this pull request
Feb 9, 2025
* LIMS-1590: Dont allow name editing for lab contacts when login is set (#887) * LIMS-1558: Add functionality for SMILES code for any sample (#880) * LIMS-1490: Use callback URL for incoming dewars via shipping service (#852) * LIMS-1570: Remove unused app file (#874) * LIMS-1537: Add more options to reprocessing (#876) * LIMS-1466: Disable dispatch form validation when using the shipping service (#891)
RichB-DLS
pushed a commit
that referenced
this pull request
Feb 11, 2025
* LIMS-1590: Dont allow name editing for lab contacts when login is set (#887) * LIMS-1558: Add functionality for SMILES code for any sample (#880) * LIMS-1490: Use callback URL for incoming dewars via shipping service (#852) * LIMS-1570: Remove unused app file (#874) * LIMS-1537: Add more options to reprocessing (#876) * LIMS-1466: Disable dispatch form validation when using the shipping service (#891)
ndg63276
added a commit
that referenced
this pull request
Apr 22, 2025
* LIMS-1612 - add util fn for generating md5. * test/LIMS-1612 - Setup Basic param tests. * feat/LIMS-1612 - implement the new md5 util across all uses of uniqId * fix/LIMS-1612 - Fix PSALM faiure * Merge pre-release/2025-R1.2 into master (#904) * LIMS-1590: Dont allow name editing for lab contacts when login is set (#887) * LIMS-1558: Add functionality for SMILES code for any sample (#880) * LIMS-1490: Use callback URL for incoming dewars via shipping service (#852) * LIMS-1570: Remove unused app file (#874) * LIMS-1537: Add more options to reprocessing (#876) * LIMS-1466: Disable dispatch form validation when using the shipping service (#891) * fix/LIMS-1612 compatibility with LIMS-1490 --------- Co-authored-by: Mark W <24956497+ndg63276@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-1590
Summary:
The synchronisation scripts from UAS to ISPyB will overwrite any changes to Lab Contact names where the
loginorexternalIdfields are set, so we should disable changing them.Changes:
login, or use "External" if theexternalIdis set.loginorexternalIdis not nullTo test:
update Person set externalId=1 where personId=267393;, then go to /contacts/cid/10731, check the login field says "External" and the name fields are not editable