Skip to content

Conversation

@ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-1783

Summary:

VMXm grid boxes are containers, but each belongs inside a Cryo-EM puck. If someone is making or viewing a grid box, we should have a selector to choose the parent container and the location within it.

Changes:

  • Add a list to the config of container types which have parent containers
  • Add backend methods for setting, getting, updating or deleting the parentContainerId and parentContainerLocaton fields
  • Display a list of potential parent containers from the same dewar as the grid box being created
  • Display an input for the location, with validation for only numeric values
  • Add validation to the container name field in the same way

To test:

  • Add to the config
$container_types_with_parents = array("VMXm-GridBox");
  • Go to a shipment (eg /shipments/sid/69454) and click Add Container
  • Check the Parent Container fields are not displayed unless the container type is a VMXm-GridBox
  • Check the dropdown shows the other containers from the same dewar
  • Check the Parent Container Location field only accepts numeric values
  • Check the Container Name field only accepts alpha-numeric, dashes and underscores
  • Create a gridbox with the parent container fields filled in, no samples are required
  • Click to view the container, check you are shown the parent container fields
  • Check you can edit the parent container and location, and only numeric values are accepted for location
  • Check you can edit the container name, and only alpha-numeric, dashes and underscores are accepted
  • Check you can set the parent container fields to nothing
  • Check you cannot set the container name to nothing
  • Go to a different container type (eg /containers/cid/329485), check no parent container fields are shown

@gfrn gfrn added the Configuration Change Pull requests which necessitate changes to SynchWeb configuration label Aug 14, 2025
@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R4.2 September 16, 2025 09:57
@ndg63276 ndg63276 merged commit 5bd26e7 into pre-release/2025-R4.2 Sep 16, 2025
2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-1783/add-parent-container-for-gridboxes branch September 16, 2025 10:06
ndg63276 added a commit that referenced this pull request Sep 30, 2025
* LIMS-1844: Update archiving messages for 'il' proposals (#977)

* LIMS-1807: Leave 'Mark Dispensing' button active until cancelled (#967)

* LIMS-1799: Checks for safety level should be case insensitive (#955)

* LIMS-1786: Add Dewars column to Shipments page (#958)

* LIMS-1426: Allow setting of pipeline when ranking samples (#950)

* LIMS-1783: Add parent container dropdown for gridboxes (#965)

* LIMS-1903: Fix display of shipping labels (#984)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Configuration Change Pull requests which necessitate changes to SynchWeb configuration Ready to Release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants