Skip to content

Conversation

@ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-1845

Summary:

PR #959 broke the dropdown for VMXi grid scans, where it shows the name of each attachment on a dropdown. This is to fix that.

Changes:

  • Re-add the 'NAME' field to the returned info

To test:

  • Go to a VMXi grid scan, eg /dc/visit/nt37104-125/id/19041028
  • Check there are 2 dropdowns on the image, one for choosing between image 1-4 (unchanged) and one for choosing between 'pia_total_intensity', 'pia_n_spots_total', 'pia_estimated_d_min', 'pia_n_spots_no_ice' and 'None'
  • Check each one shows the data slightly differently

@ndg63276 ndg63276 changed the base branch from pre-release/2025-R3.5 to pre-release/2025-R3.5.1 August 4, 2025 14:32
@ndg63276 ndg63276 merged commit 3ab3282 into pre-release/2025-R3.5.1 Aug 4, 2025
2 checks passed
@ndg63276 ndg63276 deleted the fix/LIMS-1845/fix-broken-vmxi-attachment-names branch August 4, 2025 15:09
ndg63276 added a commit that referenced this pull request Aug 26, 2025
* LIMS-742: Remove redundant 'pid' check (#961)

* LIMS-1780 / LIMS-1787: Show strategies on characterizations, auto processing on grid scans (#956)

* LIMS-1792: Allow container types from multiple villages (#960)

* LIMS-1796: Display filepath for attachments (#959)

* LIMS-1798: Only show the latest dispensing position (#952)

* LIMS-1550: Add 'Mark Dispensing' button to plate well view (#869)

* LIMS-167: Dont default to mx type for calendar/logistics views (#942)

* LIMS-1716: Multicrystal processing only shows one DC per group (#938)

* LIMS-1718: Display cluster info on multiplex jobs (#937)

* LIMS-1752: Create view for Ligand Fit pipeline (#943)

* LIMS-1833: Fix XPDF DC view (#963)

* LIMS-1845: Fix broken VMXi attachment names (#968)

* LIMS-1848: Fix bug where no container types are available (#971)

* Check type before assigning to proposal object (#975)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants